ci: skip modified target validation when no targets changed#3002
Open
juliosuas wants to merge 1 commit into
Open
ci: skip modified target validation when no targets changed#3002juliosuas wants to merge 1 commit into
juliosuas wants to merge 1 commit into
Conversation
juliosuas
force-pushed
the
fix/gnome-vcs-patched-clean
branch
from
a41a4ab to
4e4861a
Compare
juliosuas
changed the title
Author
|
Gentle maintainer ping on this small CI fix: it is still mergeable and limited to adding the missing guard on the modified-target validation pytest step. The intent is to avoid running the full live target validation suite when a deletion-only manifest change leaves |
Author
|
Fresh validation from an isolated Linux host:
This keeps the workflow change limited to skipping the validation step only when there are no modified targets to validate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validate modified targetsstep so deletion-only manifest changes do not run the full live target validation suite with an empty--chunked-sitesvalue..github/workflows/validate_modified_targets.yml.Why
The workflow already discovers changed targets and skips manifest validation, summary generation, and commenting when
changed_targetsis empty. The pytest step was the only step without the same guard, so deletion-only changes produced an emptyCHANGED_TARGETSvalue and accidentally ran validation against the entire target catalog.Proof
PATH=.venv/bin:$PATH .venv/bin/python -m pytest -q --tb=short -m 'not online and not validate_targets'-> 14 passed, 975 deselectedPATH=.venv/bin:$PATH .venv/bin/python -m pytest -q tests/test_manifest.py::test_validate_manifest_against_local_schema tests/test_ux.py tests/test_unicode.py-> 10 passed.venv/bin/python -m ruff check-> All checks passedgit diff --check upstream/master-> passed.github/workflows/validate_modified_targets.ymlwith PyYAML -> passedchanged_targetsis empty for removed targetsGNOME VCS,Patched, so the guarded validation step is skipped.